search

bcgov / TheOrgBook

A public repository of verifiable claims about organizations. A key component of the Verifiable Organization Network.
http://von.pathfinder.gov.bc.ca
Apache License 2.0
78 stars 66 forks source link

Ontario Search Results Fix #671

Closed mitovskaol closed 5 years ago

mitovskaol commented 5 years ago

not all search results are showing as expected in Ont DEV. Running a search for an exact match

https://ontvon-von-dev.pathfinder.gov.bc.ca/en/search/name?query=SUPREME%20COUNCIL%20OF%20THE%20THIRTY%20THIRD%20DEGREE%20OF%20THE%20ANCIENT%20AND%20ACCEPTED%20SCOTCH%20RITE%20OF%20FREE%20MASONRY%20OF%20THE%20STATE%20OF%20LOUISIANA

returns 14 pages of results. Instead of "AND" logic, it looks like it applies "OR".

However, for other search strings it works fine and returns the exact match.

https://ontvon-von-dev.pathfinder.gov.bc.ca/en/search/name?query=NACSMITH%20ENTERPRISE&page=1&inactive=false&revoked=false

returns only one result.

swcurran commented 5 years ago

@cywolf - what is the status of this one?

andrewwhitehead commented 5 years ago

@swcurran It's working as designed. We can also adjust the search behaviour per site if needed.

andrewwhitehead commented 5 years ago

The number of results is reduced now (to zero for the first case). It can be further reduced by ignoring words like 'association' and 'limited' in the optional results scoring; THE BELLEVILLE DRIVING AND ATHLETIC ASSOCIATION LIMITED still returns plenty of results.

mitovskaol commented 5 years ago

The business wants to the Search Result and Autocomplete to use strict "AND" logic. i.e. searching for "DATAFILE A TAB PRODUCTS COMPANY" in Ontario DEV should only return 1 results, not 2 as now - "DATAFILE" and "DATAFILE A TAB PRODUCTS COMPANY".

Reopening the ticket.

swcurran commented 5 years ago

@cywolf - please review and let us know the status. If completed, please move to QA/Review and assign to @mitovskaol.

Thanks!