search

bcgov / TheOrgBook

A public repository of verifiable claims about organizations. A key component of the Verifiable Organization Network.
http://von.pathfinder.gov.bc.ca
Apache License 2.0
78 stars 66 forks source link

The swagger header information for TOB should be instance specific - e.g. different for BC and Ontario #703

Closed swcurran closed 5 years ago

swcurran commented 5 years ago

The TOB Swagger page header appears to be hard-coded from BC - or at least has not been changed for the Ontario instance.

If not done already, make the page header configurable by TOB instance, and once done, configure the Ontario instances to have an Ontario-centric message in the header.

For Ontario Dev Swagger (URL: https://dev.von.gov.on.ca/api/v2/), the following is currently showing:

image.png

swcurran commented 5 years ago

@WadeBarnes - I just noticed that this has not been deployed. Can you take a look at doing that?

https://www.von.gov.on.ca/api/

Thanks!

WadeBarnes commented 5 years ago

Correct, the code that supports overriding the API header documentation has not been deployed to test or prod. @weiiv, It's been over a month since the last tob-api (django container) deployments to test and prod, have you had time to test the latest version to verify whether or not it can be deployed to prod?

weiiv commented 5 years ago

Wade, Olena is making another change to our TOB, and will be deployed once it’s been approved. The API change will go together.

Thanks, Ivan

From: Wade Barnes notifications@github.com Sent: March 18, 2019 11:51 AM To: bcgov/TheOrgBook TheOrgBook@noreply.github.com Cc: Wei, Ivan (MGCS) Ivan.Wei@ontario.ca; Mention mention@noreply.github.com Subject: Re: [bcgov/TheOrgBook] The swagger header information for TOB should be instance specific - e.g. different for BC and Ontario (#703)

Correct, the code that supports overriding the API header documentation has not been deployed to test or prod. @weiivhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fweiiv&data=02%7C01%7Civan.wei%40ontario.ca%7C602a2ad4da7241dabc9e08d6abb9763a%7Ccddc1229ac2a4b97b78a0e5cacb5865c%7C0%7C0%7C636885210367625397&sdata=Gry5Dv%2F42JjI8nKSWPPXXm0Z14FM3RRD%2BD9PLdBsGxM%3D&reserved=0, It's been over a month since the last tob-api (django container) deployments to test and prod, have you had time to test the latest version to verify whether or not it can be deployed to prod?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fbcgov%2FTheOrgBook%2Fissues%2F703%23issuecomment-473971057&data=02%7C01%7Civan.wei%40ontario.ca%7C602a2ad4da7241dabc9e08d6abb9763a%7Ccddc1229ac2a4b97b78a0e5cacb5865c%7C0%7C0%7C636885210367625397&sdata=kJmPBduU4irzRNDx4KR5zaJ2J%2BsPmme8a%2FnVA8XMRdk%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAf6n58pn7B-SLPM5ouZe0Xk-NEEigHkYks5vX7XLgaJpZM4ZXMVM&data=02%7C01%7Civan.wei%40ontario.ca%7C602a2ad4da7241dabc9e08d6abb9763a%7Ccddc1229ac2a4b97b78a0e5cacb5865c%7C0%7C0%7C636885210367635401&sdata=s70fEhZr8spn%2F2EdDIjwk%2BIVmaWahbZoupcwjGJvles%3D&reserved=0.

swcurran commented 5 years ago

@mitovskaol - see the notes above as to why this was assigned to you. As soon as the new updates to Ontario OrgBook are done, please assign this to Wade to deploy. It's ready to go, just needs a go ahead to be deployed.