search

bcgov / TheOrgBook

A public repository of verifiable claims about organizations. A key component of the Verifiable Organization Network.
http://von.pathfinder.gov.bc.ca
Apache License 2.0
78 stars 66 forks source link

Why is the trailing slash needed for https://www.orgbook.gov.bc.ca/api #775

Closed ianco closed 5 years ago

ianco commented 5 years ago

https://www.orgbook.gov.bc.ca/api/ ... why is the trailing slash needed? is there a way to make https://www.orgbook.gov.bc.ca/api also ok?

jljordan42 commented 5 years ago

Built von-network and TheOrgBook locally and tested with Safari a trailing / was not required for the URL to successfully resolve to the OpenAPI page. I did note a trailing slash was added at some point in the resolution process

swcurran commented 5 years ago

Some investigation was done on this and it's not clear at what level of the technical stack this requirement is coming into being. The investigation is not worth it at this time.

WadeBarnes commented 5 years ago

The recent changes fixed the issue when running local with Docker. Once deployed to OpenShift the issues persists. I’ll have to look more closely at the issue now in the deployment environment.

WadeBarnes commented 5 years ago

Updates to the proxy configuration were required; #851

WadeBarnes commented 5 years ago

The issue is resolved, although existing clients may still see the issue due to the proxy having issued permanent redirects for previous settings.

To test open an incognito browser window and browser to https://dev.orgbook.gov.bc.ca/api. You should be redirected to the swagger API page.

WadeBarnes commented 5 years ago

@jljordan42, Please test.