Remove nonce leading zero

bcgov / TheOrgBook

A public repository of verifiable claims about organizations. A key component of the Verifiable Organization Network.

http://von.pathfinder.gov.bc.ca

Apache License 2.0

78 stars 66 forks source link

Remove nonce leading zero #876

Closed ianco closed 4 years ago

swcurran commented 4 years ago

Fine to leave it like this, but probably would have been better to use the anoncreds nonce generator. At least I hope so - that's what ACA-Py is doing.

ianco commented 4 years ago

There are 2 layers of code between Orgbook and anoncreds (von-x and von-anchor) and we're already using a patched version of von-anchor to work around another issue. If OrgBook was going to be long lived I agree on doing a different fix but for now trying to patch all 3 layers of code seems overkill.

swcurran commented 4 years ago

Got it. Good call! :-)

WadeBarnes commented 4 years ago

Fixes https://github.com/bcgov/TheOrgBook/issues/874