Closed sookeke closed 2 years ago
:lock: The security scan detected 2 potential secrets in the code.
path line secret
------------------------------------ ------ ------------------
.github/workflows/api-dotnetcore.yml 132 f5f11ab3c73f737...
.github/workflows/app-react.yml 78 83c8083f22204c5...
Merging #160 (bffccdf) into dev (4ccd614) will increase coverage by
0.81%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## dev #160 +/- ##
==========================================
+ Coverage 77.16% 77.98% +0.81%
==========================================
Files 732 858 +126
Lines 12416 18089 +5673
Branches 1743 2333 +590
==========================================
+ Hits 9581 14106 +4525
- Misses 2662 3812 +1150
+ Partials 173 171 -2
Flag | Coverage Δ | |
---|---|---|
unittests | 77.98% <ø> (+0.81%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
backend/entities/Comparers/RoleRoleIdComparer.cs | 0.00% <0.00%> (-87.50%) |
:arrow_down: |
...es/Comparers/OrganizationOrganizationIdComparer.cs | 0.00% <0.00%> (-87.50%) |
:arrow_down: |
backend/entities/Helpers/MotiTableAttribute.cs | 0.00% <0.00%> (-80.00%) |
:arrow_down: |
.../Helpers/Extensions/EntityTypeBuilderExtensions.cs | 0.00% <0.00%> (-66.00%) |
:arrow_down: |
backend/api/Helpers/Reporting/ReportHelper.cs | 54.83% <0.00%> (-45.17%) |
:arrow_down: |
backend/dal/Helpers/Extensions/EntityExtensions.cs | 55.12% <0.00%> (-44.88%) |
:arrow_down: |
backend/entities/LeasePaymentFrequencyType.cs | 0.00% <0.00%> (-40.00%) |
:arrow_down: |
backend/dal/Services/LeaseService.cs | 0.00% <0.00%> (-36.67%) |
:arrow_down: |
backend/entities/Person.cs | 46.15% <0.00%> (-35.10%) |
:arrow_down: |
backend/dal/Services/BaseService.cs | 0.00% <0.00%> (-33.34%) |
:arrow_down: |
... and 543 more |
QUALITY GATE STATUS FOR pims-app: FAILED.
:lock: The security scan detected 2 potential secrets in the code.
path line secret
------------------------------------ ------ ------------------
.github/workflows/api-dotnetcore.yml 132 f5f11ab3c73f737...
.github/workflows/app-react.yml 78 83c8083f22204c5...
⚠️ GitGuardian has uncovered 6 secrets following the scan of your pull request.
Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.
🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | Secret | Commit | Filename | | | -------------- | ------------------------- | ---------------- | --------------- | -------------------- | | [13206107](https://dashboard.gitguardian.com/incidents/2221208?occurrence=13206107) | Generic High Entropy Secret | cd65e7b5103f5bcca5ca4716f35d4aa231f8942c | k8s/application/backend/deployment.yaml | [View secret](https://github.com/bcgov/ag-pssg-sdlc/commit/cd65e7b5103f5bcca5ca4716f35d4aa231f8942c#diff-066cde4443bafc4a5dae5fbee03001dbd2f772a1501f3ff14b22e1a55eb086bbL60) | | [13206568](https://dashboard.gitguardian.com/incidents/2221208?occurrence=13206568) | Generic High Entropy Secret | e5f8dc519677bb57b3d833d05aa55e18d2c78b15 | k8s/application/backend/deployment.yaml | [View secret](https://github.com/bcgov/ag-pssg-sdlc/commit/e5f8dc519677bb57b3d833d05aa55e18d2c78b15#diff-066cde4443bafc4a5dae5fbee03001dbd2f772a1501f3ff14b22e1a55eb086bbL60) | | [22825329](https://dashboard.gitguardian.com/incidents/2142334?occurrence=22825329) | SonarQube Token | 630bfdcd3ffe8ab3bd1e56129238ca7ead171f55 | .github/workflows/api-dotnetcore.yml | [View secret](https://github.com/bcgov/ag-pssg-sdlc/commit/630bfdcd3ffe8ab3bd1e56129238ca7ead171f55#diff-c2fb36e69d71936253ec00a55f97db79d0da544c5d4c500e38f5d3e454f648eaL132) | | [22825330](https://dashboard.gitguardian.com/incidents/2142334?occurrence=22825330) | SonarQube Token | 630bfdcd3ffe8ab3bd1e56129238ca7ead171f55 | .github/workflows/api-dotnetcore.yml | [View secret](https://github.com/bcgov/ag-pssg-sdlc/commit/630bfdcd3ffe8ab3bd1e56129238ca7ead171f55#diff-c2fb36e69d71936253ec00a55f97db79d0da544c5d4c500e38f5d3e454f648eaR132) | | [22825331](https://dashboard.gitguardian.com/incidents/2142335?occurrence=22825331) | SonarQube Token | 630bfdcd3ffe8ab3bd1e56129238ca7ead171f55 | .github/workflows/app-react.yml | [View secret](https://github.com/bcgov/ag-pssg-sdlc/commit/630bfdcd3ffe8ab3bd1e56129238ca7ead171f55#diff-cb825be16c6d65ca0bb2ede3e8007f6bf83c663d3b14ef7555543cc8d5a8e738L78) | | [22825332](https://dashboard.gitguardian.com/incidents/2142335?occurrence=22825332) | SonarQube Token | 630bfdcd3ffe8ab3bd1e56129238ca7ead171f55 | .github/workflows/app-react.yml | [View secret](https://github.com/bcgov/ag-pssg-sdlc/commit/630bfdcd3ffe8ab3bd1e56129238ca7ead171f55#diff-cb825be16c6d65ca0bb2ede3e8007f6bf83c663d3b14ef7555543cc8d5a8e738R78) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/detectors/generics/generic_high_entropy_secret#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/internal-repositories-monitoring/integrations/git_hooks/pre_commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!