search

bcgov / aries-oca-bundles

aries-oca-bundles
Apache License 2.0
8 stars 20 forks source link

Update the ocabundle.json generator to be more flexible about the locations of bundles #102

Closed swcurran closed 9 months ago

swcurran commented 9 months ago

Addresses issue #99 -- allowing flexibility in the location of OCA Bundles in the repo. The bundles MUST be under the OCABundles folder in the repo, but any folder found with an OCABundle.json and README.md is assumed to be a bundle and processed. This allows, for example, the mines-permit-act to be a folder, and then multiple versions of the bundle (for example, 0.3 AND 1.1.1) to be put below that. Similar adjustments can be made for the various person credential versions -- the production, showcase and unverified person ones.

Updates/simplifies the script and updates the readme.

swcurran commented 9 months ago

There is an implementation commented out in this script of a way to address #82 (adding a SHA256 for the OCABundle to the JSON), but I have a question outstanding for @cvarjao and @amanji on what has to happen to add that.

swcurran commented 9 months ago

Why not? No bash? Not executable? Just wondering what if anything you have tried.

Jsyro commented 9 months ago

Why not? No bash? Not executable? Just wondering what if anything you have tried.

Getting JQ and the excel parser in gitbash is being a pain.

swcurran commented 9 months ago

That script doesn’t use either of those executables, so it should run in a pretty stock bash instance.

Jsyro commented 9 months ago

That script doesn’t use either of those executables, so it should run in a pretty stock bash instance.

I was running the converter, not the bundler.... yes this works with just bash, the scripts runs as expected. DEFINETLY APPROVED NOW.

swcurran commented 9 months ago

Thanks! Glad you ran through it. I’ll do a PR to reorg the Mines Act Permit and regenerate.