search

bcgov / aries-oca-bundles

aries-oca-bundles
Apache License 2.0
8 stars 20 forks source link

Organize OCA Bundle folders for Mines Act Permits versions #104

Closed swcurran closed 9 months ago

swcurran commented 9 months ago

Signed-off-by: Stephen Curran swcurran@gmail.com

swcurran commented 9 months ago

@Jsyro -- please see the tweaks I made to better organize the Mines Act Permit OCA Bundle versions. I think this is a little easier to work with. Please confirm this is how you would like the folders/bundles organized.

@wadeking98 @cvarjao -- Note that in this PR, the location of the OCABundles for the Mines Act Permit will move. As such, wallets with the "ocabundles.json" already loaded will have the wrong path, and will not find (get a 404) the OCABundles.json files for the Mines Act Permit IDs -- even though they are in JSON list. Once they reload this file and get the new paths, the OCABundle.json will work resolve properly.

Question for you is what triggers a wallet to retrieve the ocabundles.json file? Worst case is that there is no branding on the credentials.

FYI: I'll be putting another PR Real Soon Now to add the SHA256 to the ocabundles.json file.

amanji commented 9 months ago

Can this be updated?

swcurran commented 9 months ago

Will do.