@andy-credivera — happy to merge, but there is one thing that should be checked, and here are some suggestions:
It looks like a last fix in the JSON was not put into the Excel — the French and English labels for “given_names” — "The first name(s) of the holder”. The Excel doesn’t have the “(s)”. We can do a follow up merge if this is urgent.
If you want, you can now do arbitrary deep folders, so you can have an “LCRB” folder, and then within it, the three credential bundles. Not required, but it might be a little easier to manage. You can also have versions as well.
It is still necessary for the ./scripts/gen_ocabundlesjson.sh script to be run as part of the PR, to update the files in the root folder. We’ll be making that a GHA, but not there yet. If you are going to update this PR, please run that and add the new credentials to the two files.
@swcurran
Good catch on the Excel files, wasn't the latest version. Updated now.
I like the nested directories, much cleaner.
Sorry for missing the gen_ocabundlesjson.sh script, it has been run.
@andy-credivera — happy to merge, but there is one thing that should be checked, and here are some suggestions:
./scripts/gen_ocabundlesjson.sh
script to be run as part of the PR, to update the files in the root folder. We’ll be making that a GHA, but not there yet. If you are going to update this PR, please run that and add the new credentials to the two files.Thanks! Let me know if you have any questions.