Closed wadeking98 closed 4 months ago
Do we need to run anything to update the checksum?
I don't think so because the actual bundle hasn't been changed. The only thing that has changed is that now the student_card:1.4 points at it instead of version 1.2
LGTM. I'll wait for @swcurran to approve.
You have to update this file: OCABundles/schema/bcgov-digital-trust/student-card/README.md to change the version.
These files will be deleted soon, and the only version available will be the ones on GitHub pages that are automatically generated from the source.
BC Wallet needs to address this issue: https://github.com/bcgov/bc-wallet-mobile/issues/1878
got it, I've updated the readme and I've run the script
Good stuff! Thanks.
Let me know when https://github.com/bcgov/bc-wallet-mobile/issues/1878 gets completed, so we can delete the two generated files from the main branch, and we use just the autogenerated ones.
BTW — should you have removed the 1.2 version from the file (by changing it to 1.4), or added the 1.4 version so the 1.2 version remained? By removing it, the 1.2 version will no longer look right - it won’t have an OCA Bundle for it.
Bumped the student showcase schema version to 1.4 to match the showcase prod environment