search

bcgov / aries-oca-bundles

aries-oca-bundles
Apache License 2.0
8 stars 20 forks source link

Added image assets to uploaded artifacts in github actions #53

Closed Gavinok closed 1 year ago

Gavinok commented 1 year ago

This should resolve the missing image asset in #52 . I haven't managed to test this yet. Alternatively I can simply have the npm scripts copy the directory themselves to the dist. To me this seems like a cleaner solution.

amanji commented 1 year ago

To mimic a production scenario, run yarn build followed by yarn serve. The output in the browser should be what is produced in a production static build of the application.

Gavinok commented 1 year ago

There doesn't seem to be a yarn serve configured as of now. Instead I ran npx vite --base ./dist/ and it displayed the image as expected. I assume the issue had more to do with the change needed to the github action which this PR should resolve.

amanji commented 1 year ago

Just for posterity the command to run was yarn build followed by yarn preview.