search

bcgov / aries-oca-bundles

aries-oca-bundles
Apache License 2.0
8 stars 20 forks source link

"attribute_character_encoding" should be renamed to "attr_character_encoding" #54

Open amanji opened 1 year ago

amanji commented 1 year ago

As per the Character Encoding Overlay in the OCA Specification, the per attribute field is unfortunately abbreviated as "attr_character_encoding". This is not aligned with other fields that use the full "attribute" name but until the OCA Specification is updated we will have to align our OCA bundles.

swcurran commented 1 year ago

Opened issue in OCA Parser. Waiting on feedback if the issue is the parser or the spec.

https://github.com/THCLab/oca-parser-xls/issues/7

amanji commented 1 year ago

I believe it is the spec that needs to be aligned. An abbreviation is also being used for "attr_standars". For now I have included both the abbreviated and full form in the OCA bundle overlay classes with a deprecated flag on the abbreviated form.