search

bcgov / aries-oca-bundles

aries-oca-bundles
Apache License 2.0
8 stars 20 forks source link

Fixed oca generation bug creating invalid JSON #81

Closed wadeking98 closed 11 months ago

wadeking98 commented 1 year ago

Previously the JSON files generated by the gen_ocabundlesjson.sh script would be invalid due to a trailing comma. This caused BC Wallet to fail to properly handle the JSON. I've added functionality to not add a comma on the last entries in the json file.

cvarjao commented 12 months ago

@amanji , @swcurran , can we get this reviewed/merged?

swcurran commented 12 months ago

Sorry about that. It keeps getting bumped from my list. I’ll try for tomorrow EOD.

swcurran commented 11 months ago

Sorry for the long delay — had it on my list, but just not getting to it.

swcurran commented 11 months ago

@jleach — are your suggestions required for merging? Can’t merge until you say OK.

FYI - a suggestion on a probably easier way to make this change, and a reasonable approach in any Bash scripts. The entire JSON output could have been passed through another sed script with a simple substitution regex to remove the trailing comma on the second last line. Bash pipelines are easy to do.