bcgov / aries-oca-bundles

aries-oca-bundles
Apache License 2.0
8 stars 20 forks source link

Draft Mines Permit OCA Bundle #86

Closed swcurran closed 11 months ago

swcurran commented 11 months ago

Here is a draft of the Mines Permit Branch. In looking at it, I wondered:

Happy to merge once these questions are answered.

FYI: @Jsyro

Thanks!

Jsyro commented 11 months ago

Here is a draft of the Mines Permit Branch. In looking at it, I wondered:

  • The data elements are all flagged as "PII" -- I'm guessing that is not correct, and that they should be "Not PII". Perhaps a misunderstanding of what the flag meant?
  • I notice that the images for the permit in the Branding JSON reference the "person" credential. Is that expected? It might well be, since it is a "Government of BC" credential, but I wanted to be sure.

Happy to merge once these questions are answered.

FYI: @Jsyro

Thanks!

We used an example that had all the attribute set as 'Flagged Attributes' it seemed odd but it also didn't seem like PII in the one we were comparing too. That can be changed if it's intention is for PII.

Yes, we found the asset from that credential and wanted the exact same asset, we can make our own copy if that is preferred, or maybe a 'shared' location should be made as I predict many BC Gov branded credentials that should be managed by one set of branding.json potentially?

swcurran commented 11 months ago

Not sure the one you were using originally, but if you were using the Person credential, it would make sense that they would be PII, since… “Person” :-) . If another one — I’d question that. But should definitely be off in this one.

I’ll make that change.

Re: the shared images. I’ll make copies of the images for now, and reference local copies. I agree, there should be a common set that are used, and on the next round, we can do that.

I’ll have that done in a moment.

swcurran commented 11 months ago

I notice in the Excel file that the Issuer and Issuer description and Issuer URL are missing. Are there not values we could use for those?

swcurran commented 11 months ago

Changes made. We can merge with/without the Issuer data, but if you have it — happy to put it in.

swcurran commented 11 months ago

We'll go ahead without the extra issuer data and add it later.

amanji commented 11 months ago

@Jsyro There are some examples that may have also incorrectly added flagged attributes that are not considered PII.