search

bcgov / aries-oca-bundles

aries-oca-bundles
Apache License 2.0
8 stars 20 forks source link

Mines Act Permit v1.1.1 OCA #94

Closed Jsyro closed 9 months ago

Jsyro commented 9 months ago

Added subfolder with version to maintain access to older version OCA.

_code attributes are now going to be their full strings. mine_party_appt is now permittee_name

swcurran commented 9 months ago

What are you expecting the “live” version to be — the one in the 1.1.1 folder, or the files in the mines-act-permit folder, or both? As the script to generate the root folder JSON files is currently desgined, it will not see or use the ones in the 1.1.1 folder. Do we need to change that?

Jsyro commented 9 months ago

Maybe....

Shouldn't all published version of schemas have OCA bundles? we have a 1.0 and a 1.1.1 version in production, those have slightly different attribute names so should have different OCA bundles.

Jsyro commented 9 months ago

I can quickly change the 0.3 (which was never pushed to production) as the subfolder one and put 1.1.1 in the root.

amanji commented 9 months ago

Technically shouldn't each version be a separate schema? So according to the README as written you'd have OCABundles/schema/<versioned_schema>/

So rather than having 1 single mines-act-permit with 2 sub versions you'd have 2 top level folders. Was that the original intention @swcurran. If the latter, id be in favour of actually renaming the folders to the correct schema names.

The only caveat is I think folder names with certain characters are an issue on Windows. See: https://stackoverflow.com/questions/1976007/what-characters-are-forbidden-in-windows-and-linux-directory-names

Jsyro commented 9 months ago

We could do that, but in our example we have published the same schema on two different ledgers, and both are valid so the txn name as the folder doesn't really help. I'll make two top level folders. We are hoping to merge ASAP, we have a workshop at 10am this morning and i'd like to share the new OCA bundle ahead of time.

swcurran commented 9 months ago

Working on it now. I like the idea of the versions within a folder — it’s just that the current script doesn’t support it. We’ll add that capability, and you will be able to go back to that structure.

swcurran commented 9 months ago

@Jsyro — given the rush, how about I do another PR with this content?

swcurran commented 9 months ago

Replaced by #95