search

bcgov / aries-vcr-issuer-controller

indy-catalyst-agent
Apache License 2.0
8 stars 31 forks source link

Integration and API Testing #63

Closed ianco closed 3 years ago

ianco commented 3 years ago

Based on the API testing script by Akiff

ianco commented 3 years ago

Script is working, next step is figure out how to run it in a GHA

WadeBarnes commented 3 years ago

It may be possible to speed things up a bit by starting up von-network and aries-vcr in parallel, though you would need a way to sync the two since the aries-vcr agents need to connect to the ledger. There is currently no official way to run steps in parallel, although there are a couple workarounds mentioned here; https://github.community/t/steps-in-parallel/16343

swcurran commented 3 years ago

What about using one of the BCovrin instances instead of von-network?

WadeBarnes commented 3 years ago

What about using one of the BCovrin instances instead of von-network?

I like the fact that the tests are independent of any hosted ledger - personal opinion.

ianco commented 3 years ago

The only difference is that with a local von-network we use the same DID (and therefore cred def id) on everyrun, whereas with a persistent ledger we need to create a new (different) DID for each run. As long as these differences don't leak into the aries-vcr api output then it's no issue using one of the bcovrin ledgers.

ianco commented 3 years ago

Switched the tests to use the dev bcovrin ledger. Personally I prefer using the built-in/local von-network, as the bcovrin ledger introduces an external dependency to the tests. Running a local von network adds 30-40 seconds out of about 9 minutes overall to run the full process.

swcurran commented 3 years ago

I was only suggesting that because there was some question about the scripts not running because there was too much going on. I'm good with a local ledger as long as it doesn't break the process. Sorry if that wasn't clear.