search

bcgov / aries-vcr

Hyperledger Aries Verifiable Credential Registry (VCR) is a set of application level software components designed to accelerate the adoption of trustworthy entity to entity communications.
Apache License 2.0
78 stars 70 forks source link

Aries VCR Org Number Search is case sensitive #508

Closed ianco closed 3 years ago

ianco commented 4 years ago

I just discovered Orgbook is case sensitive. When I enter bc0491266 it says No Results however BC0491266 finds the company. I’ve tried this with a couple different sole props and the same thing happened. This seems like a major flaw in searching for entities.

ianco commented 4 years ago

This is a bug in the V2 API's

In the V3 API's it's a mixed bag, the /search/autocomplete endpoint is not case sensitive ("bc0491266" and "BC0491266" both return the same results), however the /search/credential and /search/topic endpoints are both case sensitive on the company number (nut not the company name or address).

So, if we switch over to the V3 API's and hook up the name search to the /search/autocomplete endpoint it will fix this issue. (Or we can fix the other endpoints to be case in-sensitive)