search

bcgov / aries-vcr

Hyperledger Aries Verifiable Credential Registry (VCR) is a set of application level software components designed to accelerate the adoption of trustworthy entity to entity communications.
Apache License 2.0
78 stars 67 forks source link

revert: v4 search autocomplete endpoint #746

Closed amanji closed 1 year ago

amanji commented 1 year ago

Signed-off-by: Akiff Manji akiff.manji@quartech.com

This PR reverts/removes the v4 search autocomplete endpoint introduced in PR #734

A number of issues were introduced causing confustion in search results and UI artifacts in OrgBook BC

WadeBarnes commented 1 year ago

@amanji, Will there be an associated PR for the OrgBook Client? I'm assuming not, as it seems to be using the v3 endpoint. What affect do the changes to the api/v3 code have on things?

@esune, Who is tasked with checking in with the affected users? I'll wait for the confirmation before deploying.

esune commented 1 year ago

@esune, Who is tasked with checking in with the affected users? I'll wait for the confirmation before deploying.

@amanji and/or myself will reach out to them to confirm.

amanji commented 1 year ago

There won't be an associated change to the client. I checked to make sure that we hadn't deployed /v4 autocomplete. /v3 autocomplete will be affected since search suggestions on Topic Name will no longer be effective. Inclusion of that search filter was creating issues with search results. This change should not affect any users of the /v3 or /v4 search topic or credential endpoints.

WadeBarnes commented 1 year ago

@esune, @amanji, These changes have been deployed to dev and test.