search

bcgov / bc-aquifer-dashboard

A dashboard/portal for viewing and querying provincial aquifer data
Apache License 2.0
4 stars 1 forks source link

json2array duplicated in makeagraph.js #10

Open IanLaingBCGov opened 6 years ago

IanLaingBCGov commented 6 years ago

the same json2array occurs in two different functions in makeagraph.js:

wburt commented 6 years ago

Scope is ok? no?

IanLaingBCGov commented 6 years ago

They're both locally scoped, which is fine. But the functions are doing the same thing at first, which is, json2array. It'd be better if json2array is done once and then use by both functions.

GrahamMacGregorBCGov commented 6 years ago

was aware of this and will clean it up to be more efficient