bcgov / bc-wallet-mobile

BC Wallet to hold Verifiable Credentials
Apache License 2.0
62 stars 50 forks source link

Person Credential rendering #1047

Closed cvarjao closed 1 year ago

cvarjao commented 1 year ago

In the "credential offer" and "credential details" screens, it is showing attributes that are not used by BC Person Credential. While the schema has a list of all possible attributes, the Capture Base overlay defines an ordered list of attributes applicable to a schema or credential definition ID.

https://github.com/bcgov/bc-wallet-mobile/blob/92cb4a0a91a4f032dbb5b308673b1df8a0fdde48/app/src/assets/branding/credential-branding.ts#L148

For example, "Picture" and "Expiry Dateint" are not attributed we are using for BC Person Credential (yet)

wadeking98 commented 1 year ago

Resolved by: https://github.com/hyperledger/aries-mobile-agent-react-native/pull/730