bcgov / bc-wallet-mobile

BC Wallet to hold Verifiable Credentials
Apache License 2.0
62 stars 50 forks source link

Update Practicing lawyer and person photo attribute proof request template #1287

Closed knguyenBC closed 1 year ago

knguyenBC commented 1 year ago

Description of feature / user story

As a corrections facility officer, I want to be able to request for the following attributes from the Person and the Lawyer Member Card credential

Acceptance Criteria

Proof request:

From a non-revoked Person credential

From a non-revoked LSBC issued lawyer member card

Name of proof request template = Lawyer Status and Photo

Wireframes or relevant image assets / links

hiteshgh commented 1 year ago

@wadeking98 - assume you are already working on this story, if yes can you pls update the estimate move to In-progress column

wadeking98 commented 1 year ago

Right now this is blocked by: https://github.com/hyperledger/aries-framework-javascript/issues/1536

knguyenBC commented 1 year ago

double check proof request definition if member status code is necessary.

hiteshgh commented 1 year ago

unblocked and moved to In progress( per Aug 15 refinement )

knguyenBC commented 1 year ago

I had updated the proof request name to "Lawyer Status and Photo" as its not specifically asking for a practising lawyer, just asking for lawyer status.

knguyenBC commented 1 year ago

Regarding the request for the practicing code, its best to leave the code in as LSBC is unsure how they'll deal with the code when they add other member types to register to LSBC. Ex. paralegals are currently not registered but might be in the future and their practicing code MAY differ.

wadeking98 commented 1 year ago

Resolved by https://github.com/bcgov/bc-wallet-mobile/pull/1390

knguyenBC commented 1 year ago

Looks good. Works.