bcgov / bc-wallet-mobile

BC Wallet to hold Verifiable Credentials
Apache License 2.0
62 stars 50 forks source link

Link in message missing link accessibillity label #1453

Open knguyenBC opened 1 year ago

knguyenBC commented 1 year ago

Description of problem

In messages that are sent from a contact that contains a link, the link is missing the "link" accessibility label/role. When focused, the link is read out but a non-sighted person will not know if it's a link they can tap.

Expected behavior

Should contain the link accessibility role/label. It normally reads out as "[text of hyperlink]...Link"

Steps to reproduce

Screenshots and/or log output

Environment

Build #: 1193

Android Device Model: OnePlus 6

iOS Device Model: iPhone SE

Workaround

Severity

bryce-mcmath commented 1 year ago

The accessibilityRole of link in nested Text elements is not picked up on iOS until RN 0.69, so we'll have to wait until after our React Native upgrade to fix this one

wadeking98 commented 1 year ago

resolved by: https://github.com/hyperledger/aries-mobile-agent-react-native/pull/998

jleach commented 1 year ago

Tested on 1.0.12 1325 and I don't see any accessibility labels on the link in chat:

IMG_9D0F150ADF20-1

bryce-mcmath commented 1 year ago

Until we start using the new RN architecture (with Fabric) inline nested links will not have accessibility features. This can be avoided in the interim by using the Link component outside of the text surrounding it. It's not an elegant solution but it's the only one that works for now

jleach commented 1 year ago

This may require a re-think. Moving out of this sprint to est ready.