search

bcgov / bc-wallet-mobile

BC Wallet to hold Verifiable Credentials
Apache License 2.0
60 stars 45 forks source link

Support For Indigenous Languages (UTF-8) #1503

Open cvarjao opened 11 months ago

cvarjao commented 11 months ago
nodlesh commented 11 months ago

Tested with Schema Name and Credential Definition ID containing Special Characters. This is with an ACA-Py Issuer and Verifier. The test passed except for the display of the credential name. "credential_definition_id": "AmzL2hSP2gPm9DuQBLVcy8:3:CL:77962:driverslicense!@#$%^&(0", "schema_id": "AmzL2hSP2gPm9DuQBLVcy8:2:driverslicense!@#$%^&(0:1.0.0" Credential Name displays as Drivers License 0 in BC Wallet. Private Zenhub Image

Private Zenhub Image

Private Zenhub Image

cvarjao commented 11 months ago

@nodlesh, we are talking about characters outside the ASCII table. Emojis are example of such characters.

nodlesh commented 11 months ago

'credential_definition_id': 'GK9qMoQLZdPHXEAEvLWJG6:3:CL:77998:driverslicense😀' 'schema_id': 'GK9qMoQLZdPHXEAEvLWJG6:2:driverslicense😀:1.0.0'

Receiving the credential did ok and even displayed in BC Wallet correctly. However, the proof didn't work and the Credential name was displayed improperly in BC Wallet. Private Zenhub Image

Private Zenhub Image

Private Zenhub Image

Private Zenhub Image

This seems to be an issue with BC Wallet or AFJ and not in the ACA-Py Verifier. The verifier sends the proof request and never hears back from the Wallet.

cvarjao commented 11 months ago

@nodlesh , what version of aca-py is AMTH using?

nodlesh commented 11 months ago

@cvarjao This above was right out of main. We mostly test the wallet with ACA-Py main. I can just as easily do the official ACA-Py release version if that helps?

cvarjao commented 11 months ago

@nodlesh , I am confused how you get it working in your tests. What build of BC Wallet did you run against?

nodlesh commented 11 months ago

@cvarjao It was 1215 or 1216. Not sure what the confusion is? AMTH uses AATH agents as Issuer and Verifier agents for testing the wallet. Those agents can be built from main or release.

cvarjao commented 11 months ago

Have you tried using an emoji in the invitation label? where I see as "aca-py.Acme"/"aca-py.Bob"?

nodlesh commented 11 months ago

Not yet.