bcgov / bc-wallet-mobile

BC Wallet to hold Verifiable Credentials
Apache License 2.0
62 stars 49 forks source link

Wallet wrongly detects BCSC app installed after going back from app store #1904

Open knguyenBC opened 7 months ago

knguyenBC commented 7 months ago

Issue

When the user enters the Person credential issuance screen from the BC Wallet (the screen where you start the process from BC Wallet). BC Wallet correctly determines that the BCSC app IS NOT installed HOWEVER when they tap to install the app and then go back to the BC Wallet without installing the BCSC app, the screen changes to wrongly determine the BCSC all was installed.

Steps to reproduce

OS affected

Android iOS

Devices

iPhone 12 Google Pixel

cvarjao commented 7 months ago

@knguyenBC , note that this is only for non-production

knguyenBC commented 7 months ago

@knguyenBC , note that this is only for non-production

non-production of what? I tried with the app store version of the BC Wallet (1.0.15), without any BCSC app installed.

jleach commented 1 month ago

Confirmed in latest 1.0.21 build.

jleach commented 4 days ago

The BSCS v3.10.0 has some some registered that we could use. Once the feature is enabled we can register our app to be able to query the appropriate schemas. This will allow us to check if that app is installed or not and direct people to the app store accordingly

<key>LSApplicationQueriesSchemes</key>
<array>
  <string>myapp</string>
  <string>anotherapp</string>
</array>