Closed loneil closed 1 month ago
@loneil trying to reproduce this, I'm assuming I need to set some config arguments or something? I'm not running into it with the default configuration
@wadeking98 yeah I would reproduce this with VCAuth-N, think that would be easiest/applicable to the current use case.
If you use VCAuth-N locally you can go into manage
and set the
USE_OOB_PRESENT_PROOF
USE_URL_DEEP_LINK
exports to true
Then start it up. Depending on lcoal setup might need to start up demo app and then send the link from the QR code page when logging in to your mobile using IP address instead of localhost (that's how I test deep links locally at least)
Or I can set the dev environment up to have those settings as well if you ping me. Then you could just go to a2a-dev on a mobile (but we probably wouldn't want to leave that env permanently set up like that at this time)
I've created a PR to fix this: https://github.com/openwallet-foundation/bifold-wallet/pull/1197. We're still running into an issue due to the acapy / credo empty handshake thing here: https://github.com/bcgov/vc-authn-oidc/issues/583 but once that's fixed then we should be good to go
Jason's changes actually fix this now, but to properly test you'll have to spin up vc-authn locally and comment out the handshake_protocols
field from out_of_band.py
👍
Note handshake protocol part was commented out and merged back in https://github.com/bcgov/vc-authn-oidc/pull/582 so just getting from main
should suffice
fixed in the latest build
Description of problem
Using a
https://didcomm.org/out-of-band/1.1/invitation
with the proof attached is how we are doing OOB proofs in VCAuth-N. This is working successfully when scanning a QR code with the BC Wallet camera. But using the same link that the QR code resolves to, but packed into the?_url
deep-link handler results in an "Unable to handle deep link" error:I've only tried this on Android.
Expected behavior
The link that fetches the OOB envelope works in a deep link the same as it works in the QR code, and opens the proof in the BC Wallet.
Steps to reproduce
Can use VCAuth-N with the ?_url handler enabled and the OOB invitation mode on to reproduce this. Or some other setup that will provide a redirect link to an OOB envelope with a proof request in it.
bcwallet://aries_proof-request?_url=<base64 encoded redirect url to OOB proof>
Screenshots and/or log output
OOB Deep Link with VCAuth-N
https://github.com/bcgov/bc-wallet-mobile/assets/17445138/17d10b27-c093-4fc6-8a26-3a96b7a82010
Now, showing the same type of setup as above, but working successfully with a QR code scan
https://github.com/bcgov/bc-wallet-mobile/assets/17445138/dca0db2e-4fc1-4c61-a1cf-c28f4cf34e2a
Environment
Build #: 1.0.18 Build(1782)
Android Device Model: Pixel 8
iOS Device Model:
Workaround
Severity