Offers and proofs on wrong side of chat

jleach commented 1 month ago

In the chat window, messages you receive (like credential offers and proof requests) will appear on the left side. Messages you send from your BC Wallet will appear on the right side. This helps you easily see who sent which message. Right now offers and proof messages appear on the wrong side.

jeznorth commented 1 month ago

@knguyenBC can you verify the UI is behaving as expected.

knguyenBC commented 1 month ago

I reviewed old designs and how it's implemented now is NOT the intention.

The intention was to have whoever sent the message for the message to be displayed on their side. So proof requests and credentials offers should be displayed from their side. As shown here.

The message should state "[Connection name] is requesting for information" or "[Connection name] is offering you a new credential"

cvarjao commented 1 month ago

@knguyenBC,

received proof request shows on "their" side, but once that proof request is accepted/declined, does it switch to "my" side?
sent proof request (from mobile verifier) shows on "my" side. once there is a response, does it switch to "their" side?

knguyenBC commented 1 month ago

Please switch the chat bubble to the holder. Here's some ACs for clarity.

Given a proof request was sent over a connection When the holder shares information Then the chat bubble will switch to the holder side with the content updating to "you shared information" and the button will update to view

Given a proof request was sent over a connection When the holder declines to share information Then the chat bubble will switch to the holder side with the content updating to "you rejected a proof request" and the button is removed

Given a credential offer was sent over a connection When the holder accepts the offer Then the chat bubble will switch to the holder side with the content updating to "you received a credential" and the button will update to view

Given a proof request was sent over a connection When the holder declines the offer Then the chat bubble will switch to the holder side with the content updating to "you declined a credential offer" and the button is removed

Example:

bcgov / bc-wallet-mobile

Offers and proofs on wrong side of chat #2212