bcgov / bc-wallet-mobile

BC Wallet to hold Verifiable Credentials
Apache License 2.0
61 stars 49 forks source link

Invalid QR Code by vc-authn-oidc project #682

Closed Jsyro closed 2 years ago

Jsyro commented 2 years ago

I'm using the vc-authn-oidc project locally (configured with the bcovrin test ledger) and the qr code is 'Invalid'.

The 'Open in a Trusted Digital Wallet' link is as follows.

didcomm://launch?d_m=eyJAaWQiOiI4ZmNmOWVkYS00MGVkLTRmYTUtYTkyMi1iZTFkNTI3NWU3ODYiLCJAdHlwZSI6ImRpZDpzb3Y6QnpDYnNOWWhNcmpIaXFaRFRVQVNIZztzcGVjL3ByZXNlbnQtcHJvb2YvMS4wL3JlcXVlc3QtcHJlc2VudGF0aW9uIiwicmVxdWVzdF9wcmVzZW50YXRpb25zfmF0dGFjaCI6W3siQGlkIjoibGliaW5keS1yZXF1ZXN0LXByZXNlbnRhdGlvbi0wIiwibWltZS10eXBlIjoiYXBwbGljYXRpb24vanNvbiIsImRhdGEiOnsiYmFzZTY0IjoiZXlKdVlXMWxJam9pUW1GemFXTWdVSEp2YjJZaUxDSnVZVzFsY3lJNmJuVnNiQ3dpZG1WeWMybHZiaUk2SWpFdU1DSXNJbTV2Ym1ObElqb2lORGMyTXpZM05qSTFOalF3TnpNek56UTRNREF3T0Rjeklpd2ljbVZ4ZFdWemRHVmtYMkYwZEhKcFluVjBaWE1pT25zaU56STNOVGRqWm1RdE1UVmhNeTAwTnpBeUxXSTJNV1V0WWpObU4yUXhPVFkwTW1JNElqcDdJbTVoYldVaU9pSmxiV0ZwYkNJc0luSmxjM1J5YVdOMGFXOXVjeUk2VzExOUxDSXhPV0V4TlRWaE9DMDFZemxpTFRRMVl6WXRZakJrTmkwek4yRTROREl5TnpobU1HRWlPbnNpYm1GdFpTSTZJbVpwY25OMFgyNWhiV1VpTENKeVpYTjBjbWxqZEdsdmJuTWlPbHRkZlN3aU1HRXhNbU0xTmpndE9HVm1NeTAwTm1FeExUZzRNMkV0TTJKbVpUVTFabVUxT1RWbUlqcDdJbTVoYldVaU9pSnNZWE4wWDI1aGJXVWlMQ0p5WlhOMGNtbGpkR2x2Ym5NaU9sdGRmWDBzSW5KbGNYVmxjM1JsWkY5d2NtVmthV05oZEdWeklqcDdmWDA9In19XSwiY29tbWVudCI6bnVsbCwifnNlcnZpY2UiOnsicmVjaXBpZW50S2V5cyI6WyJGWW1vRnc1NUdlUUg3U1JGYTM3ZGt4MWQyZFozelVGOGNrZzd3bUw3b2ZONCJdLCJyb3V0aW5nS2V5cyI6bnVsbCwic2VydmljZUVuZHBvaW50IjoiaHR0cDovLzE3Mi4xNy4wLjE6NTY3OSJ9fQ==

Which decodes to:

{"@id":"8fcf9eda-40ed-4fa5-a922-be1d5275e786","@type":"did:sov:BzCbsNYhMrjHiqZDTUASHg;spec/present-proof/1.0/request-presentation","request_presentations~attach":[{"@id":"libindy-request-presentation-0","mime-type":"application/json","data":{"base64":"eyJuYW1lIjoiQmFzaWMgUHJvb2YiLCJuYW1lcyI6bnVsbCwidmVyc2lvbiI6IjEuMCIsIm5vbmNlIjoiNDc2MzY3NjI1NjQwNzMzNzQ4MDAwODczIiwicmVxdWVzdGVkX2F0dHJpYnV0ZXMiOnsiNzI3NTdjZmQtMTVhMy00NzAyLWI2MWUtYjNmN2QxOTY0MmI4Ijp7Im5hbWUiOiJlbWFpbCIsInJlc3RyaWN0aW9ucyI6W119LCIxOWExNTVhOC01YzliLTQ1YzYtYjBkNi0zN2E4NDIyNzhmMGEiOnsibmFtZSI6ImZpcnN0X25hbWUiLCJyZXN0cmljdGlvbnMiOltdfSwiMGExMmM1NjgtOGVmMy00NmExLTg4M2EtM2JmZTU1ZmU1OTVmIjp7Im5hbWUiOiJsYXN0X25hbWUiLCJyZXN0cmljdGlvbnMiOltdfX0sInJlcXVlc3RlZF9wcmVkaWNhdGVzIjp7fX0="}}],"comment":null,"~service":{"recipientKeys":["FYmoFw55GeQH7SRFa37dkx1d2dZ3zUF8ckg7wmL7ofN4"],"routingKeys":null,"serviceEndpoint":"http://172.17.0.1:5679"}}

Screenshot_20221031-121631

swcurran commented 2 years ago

@cvarjao -- could you please have one of the devs work with @Jsyro (Traction Team) on this? I suspect a documentation update is needed, but not sure. This is (I think!) working for the Lawyer A2A access use case. It better be!! :-)

Thanks!

Jsyro commented 2 years ago

I didn't make any changes to the vc-authn-oidc application. However after double checking this morning... all of Trinsic, estatus, Holdr+, and BC Wallet think this QR code is invalid.

I don't get any explanation on why, so i will investigate myself and report back.

Jsyro commented 2 years ago

closing for now as this does not appear to be a BC Wallet App issue.

Jsyro commented 2 years ago

An inaccessible serviceEndpoint will cause the QR Code to be 'invalid', which I think is a bit misleading. Not a BC Wallet issue. Disregard.