search

bcgov / bc-wallet-mobile

BC Wallet to hold Verifiable Credentials
Apache License 2.0
60 stars 45 forks source link

Unreadable credential due to randomized color and lack of contrast #767

Closed PatStLouis closed 1 year ago

PatStLouis commented 1 year ago

While working on some PoC, I came across an unreadable color combination for the credential (see attached picture).

It would be great to limit to possible colors to something with more contrast and limit the whites/pale colors to be able to read the text.

Untitled

nodlesh commented 1 year ago

@amanji Any idea how I can test this?

amanji commented 1 year ago

You'll have to test with an unbranded credential. Any way you can issue one from the Faber ACA-Py demo?

nodlesh commented 1 year ago

I have been using unbranded credentials for a year with the AATH agents. I have never seen yellow. Mine seem to always be green or brown with black text. Though I have seen only a fraction of the credential screens from all the test runs.

What was the fix? You are blocking certain colours from being used? If so what ones?

@PatStLouis is there a specific way to reproduce this or verify in the current build that it is fixed or was the yellow random?

amanji commented 1 year ago

This fix should be that text appears dark on light backgrounds and appears light on dark backgrounds. Currently text is always light.