search

bcgov / bcbb-theme

A theme for the Drupal base build used to streamline the build and deployment of applications at Ministry of Finance.
GNU General Public License v2.0
1 stars 0 forks source link

Use icon in header search bar #14

Closed CraigClark closed 1 year ago

CraigClark commented 1 year ago

OP timer

https://openplus.monday.com/boards/4092908516/pulses/5046827648

In the search bar in the header, use an icon instead of text for search. To do this, replace this html

<input class="btn btn-default button js-form-submit form-submit btn-primary" data-drupal-selector="edit-submit" type="submit" id="edit-submit" name="op" value="Submit">

with

<button class="btn btn-default button js-form-submit form-submit btn-primary" data-drupal-selector="edit-submit" type="submit" id="edit-submit" name="op" value="Submit"><i class="fa-solid fa-magnifying-glass"></i><span class="visually-hidden">search</span></button>

Note: This change should happen in the base-build and be brought down to projects.

screenshot

The search block should look like the one on the bottom

image

CraigClark commented 1 year ago

When this is done, please show me. I'd like to know how to make this type of change

lkmorlan commented 1 year ago

This change was implemented by the theme change in this repository plus this change: https://github.com/bcgov/bcbb/commit/0e9b9b23bb716dbb141eb01d6558989765070890

CraigClark commented 1 year ago

Reviewed and approved on dv21