search

bcgov / bcdata

An R package for searching & retrieving data from the B.C. Data Catalogue
https://bcgov.github.io/bcdata
Apache License 2.0
81 stars 12 forks source link

dbplyr 2.0 release - DBI S4 methods #225

Closed ateucher closed 2 years ago

ateucher commented 3 years ago

From https://github.com/tidyverse/dbplyr/blob/master/NEWS.md: DBI::dbQuoteIdentifier() is now used instead of sql_escape_ident() andDBI::dbQuoteString() instead of sql_escape_string().

Requires importing DBI and new S4 methods for those DBI generics. Some initial guidance here: https://dbplyr.tidyverse.org/dev/articles/backend-2.html. I think those are the only changes that impact bcdata

ateucher commented 3 years ago

Looks like there might also need to be a change to sql_translate_env: https://github.com/tidyverse/dbplyr/issues/385#issuecomment-697686071

ateucher commented 3 years ago

sql_translate_env -> sql_translation here: https://github.com/tidyverse/dbplyr/commit/be9b1aa5d4572cce0da1cca5ac924cc2a7d3af45

ateucher commented 2 years ago

Closed by #300