Closed ateucher closed 1 year ago
If you haven't already submitted, would you mind holding off until I can get you a fix for dev dbplyr?
Hmmm, I can't reproduce locally, so I think you might've already fixed the problem. With CRAN bcgov I see:
── Failure ('test-cql-string.R:87'): unsupported aggregation functions fail correctly ──
`filter(structure(list(), class = "bcdc_promise"), mean(x) > 5)` threw an error with unexpected message.
Expected match: "not supported by this database"
Actual message: "Object `x` not found."
── Error ('test-query-geodata-filter.R:82'): Different combinations of predicates work ──
Error: Object `POP_2000` not found.
── Error ('test-query-geodata-filter.R:121'): subsetting works locally ─────────
Error: Object `foo` not found.
Oh yeah, it was https://github.com/bcgov/bcdata/issues/304 😄
Yeah, I think we have a fix in place for this via #305. But let me know if you see anything else wonky!
Finally tweeted+tooted!
Prepare for release:
git pull
devtools::build_readme()
urlchecker::url_check()
devtools::check(remote = TRUE, manual = TRUE)
devtools::check_win_devel()
revdepcheck::revdep_check(num_workers = 4)
cran-comments.md
git push
Submit to CRAN:
usethis::use_version('minor')
devtools::submit_cran()
Wait for CRAN...
git push
usethis::use_github_release()
usethis::use_dev_version()
git push