bcgov / bcdata

An R package for searching & retrieving data from the B.C. Data Catalogue
https://bcgov.github.io/bcdata
Apache License 2.0
81 stars 12 forks source link

Release bcdata 0.4.0 #308

Closed ateucher closed 1 year ago

ateucher commented 1 year ago

Prepare for release:

Submit to CRAN:

Wait for CRAN...

hadley commented 1 year ago

If you haven't already submitted, would you mind holding off until I can get you a fix for dev dbplyr?

hadley commented 1 year ago

Hmmm, I can't reproduce locally, so I think you might've already fixed the problem. With CRAN bcgov I see:


── Failure ('test-cql-string.R:87'): unsupported aggregation functions fail correctly ──
`filter(structure(list(), class = "bcdc_promise"), mean(x) > 5)` threw an error with unexpected message.
Expected match: "not supported by this database"
Actual message: "Object `x` not found."

── Error ('test-query-geodata-filter.R:82'): Different combinations of predicates work ──
Error: Object `POP_2000` not found.

── Error ('test-query-geodata-filter.R:121'): subsetting works locally ─────────
Error: Object `foo` not found.
hadley commented 1 year ago

Oh yeah, it was https://github.com/bcgov/bcdata/issues/304 😄

ateucher commented 1 year ago

Yeah, I think we have a fix in place for this via #305. But let me know if you see anything else wonky!

stephhazlitt commented 1 year ago

Finally tweeted+tooted!