Images optimization - Githubissues

bcgov / bcdevexchange

Code for the BCDevExchange website

https://bcdevexchange.org

Apache License 2.0

3 stars 0 forks source link

Images optimization #50

Closed mark-a-wilson closed 4 years ago

mark-a-wilson commented 4 years ago

Per the B.C. Government Accessibility & Inclusion Toolkit, correct/enhance the accessibility of images across the site.

Commits include:

NEX-77 - making file names (and folders) descriptive and consistently formatted
NEX-78 - adding alt="" text to all images (some exceptions)
NEX-80 - compressing all images to ~≤250KB

parulmishra commented 4 years ago

SonarQube Analysis: https://sonarqube-ifttgq-tools.pathfinder.gov.bc.ca/dashboard?id=BCDevExchange-PR-50

parulmishra commented 4 years ago

SonarQube Analysis: https://sonarqube-ifttgq-tools.pathfinder.gov.bc.ca/dashboard?id=BCDevExchange-PR-50

mark-a-wilson commented 4 years ago

@parulmishra - could you please investigate what has caused my PR not to build? Let me know if I've made errors that need to be corrected. Thank you!

parulmishra commented 4 years ago

SonarQube Analysis: https://sonarqube-ifttgq-tools.pathfinder.gov.bc.ca/dashboard?id=BCDevExchange-PR-50

parulmishra commented 4 years ago

@parulmishra - could you please investigate what has caused my PR not to build? Let me know if I've made errors that need to be corrected. Thank you!

@mark-a-wilson Try redeploying

parulmishra commented 4 years ago

SonarQube Analysis: https://sonarqube-ifttgq-tools.pathfinder.gov.bc.ca/dashboard?id=BCDevExchange-PR-50

mark-a-wilson commented 4 years ago

Build failed due to this branch being behind develop, in which changes had been made to the pipeline. Will start with a new, fresh branch off of develop and re-submit.