search

bcgov / bcdg

This is bcdg
Other
1 stars 6 forks source link

Missing PHP #46

Closed kmarshgov closed 1 month ago

kmarshgov commented 2 months ago

https://github.com/bcgov/bcdg/blob/1ca6afc63802f5a292bedffca43c62012b096a16/docs/choosing-technology/how-to-select-technology.md?plain=1#L13

and missing Laravel as a backend framework.

jenreiher-bcgov commented 2 months ago

Hi @kmarshgov thanks for your feedback, good call. We are open to PRs on this documentation - would you interested in contributing?

kmarshgov commented 2 months ago

@jenreiher-bcgov I tried to do a PR but not sure why it failed the checks. Regardless, the changes I'm suggesting are minor if you'd like to add them.

jenreiher-bcgov commented 2 months ago

@kmarshgov this is expected - we have something in our backlog to improve, but haven't gotten there yet. I'll review - thank you so much for your contribution! We appreciate it.

MonicaG commented 1 month ago

Closing as this was merged in #47 Feel free to reopen if this was not the case