search

bcgov / bcgovr

An R package to automate set up and sharing of R projects in bcgov GitHub following bcgov guidelines
Apache License 2.0
34 stars 5 forks source link

Use rstudioapi functions #16

Closed ateucher closed 7 years ago

ateucher commented 7 years ago

rstudioapi v0.7.0 is on CRAN now and has the initializeProject and openProject functions, which we have commented out currently. I think we can use them now.

boshek commented 7 years ago

For analysis_skeleton a new rstudio session will open the appropriate directory:

https://github.com/bcgov/bcgovr/blob/b0caface0e8a9166be24fe6d5e6e28a9afd425fb/R/analysis_skeleton.R#L139-L147

For package_skeleton only a project is created but rstudio is not opened automatically:

https://github.com/bcgov/bcgovr/blob/b0caface0e8a9166be24fe6d5e6e28a9afd425fb/R/package_skeleton.R#L54-L61

The thinking here is that if a user is using the package_skeleton() that type of automated behaviour is less desirable.

ateucher commented 7 years ago

Looks great to me! I think we can remove the commented-out code now too...