Fixing readGWLdata to work with new data

bcgov / bcgroundwater

An R package to facilitate analysis and visualization of groundwater data from the British Columbia groundwater observation well network

Apache License 2.0

20 stars 4 forks source link

Fixing readGWLdata to work with new data #10

Closed steffilazerte closed 6 years ago

steffilazerte commented 6 years ago

This pull does the following:

adds a new function get_gwl to download well data (including documentation)
adds tests to ensure the working of downstream functions
updates the vignette to use get_gwl
removes most global variables (but see comments on issue #1)

steffilazerte commented 6 years ago

Also forgot to mention: The only thing missing from the downloaded/formatted data is two additional metadata fields: EMS_ID and Station_Name. Right now they're filled with NA, and I'm not sure where to get the information from without web-scraping the well details (for example, but even this one doesn't have an EMS ID...).

ateucher commented 6 years ago

Thanks @steffilazerte! I'll try and have a look today or tomorrow.

steffilazerte commented 6 years ago

Commit 225c64e was odd. In order to keep rgdal and sp as suggests and to avoid a check error, I had to manually delete their 'import' lines from the NAMESPACE. But if I reran devtools::document() those import lines would be added back in... possibly a bug in document()?