search

bcgov / bcgroundwater

An R package to facilitate analysis and visualization of groundwater data from the British Columbia groundwater observation well network
Apache License 2.0
20 stars 4 forks source link

Option to increase maximum number of iterations for makeWellTS? #21

Open steffilazerte opened 6 years ago

steffilazerte commented 6 years ago

makeWellTS returns a message indicating any problems with convergence (also, perhaps that should be message() rather than print()?).

Code 1 reflects the fact that the maximum number of iterations have been reached before convergence (According to the optim documentation). What about an argument allowing the user to pass options via optim.control in the call to StructTS? This should allow users to increase the maximum number of iterations if they need to.

ateucher commented 6 years ago

I think that's a good idea! Also if you think there's a better way to fill in the missing values, please feel free to suggest it.

steffilazerte commented 6 years ago

I hadn't really looked into dealing with missing values, the only reason I came up with this idea, is because I ran into the code 1 convergence warning :) I'll let you know if anything comes to me, though.