search

bcgov / bcgroundwater

An R package to facilitate analysis and visualization of groundwater data from the British Columbia groundwater observation well network
Apache License 2.0
20 stars 4 forks source link

bcgroundwater::get_gwl() bonks when *-minMaxMean.csv file has NAs #29

Closed stephhazlitt closed 5 years ago

stephhazlitt commented 5 years ago

bcgroundwater::get_gwl(wells = 444)

Retrieving data...
Formatting data...
Error in left_join_impl(x, y, by_x, by_y, aux_x, aux_y, na_matches) : 
  Can't join on 'dummydate' x 'dummydate' because of incompatible types (logical / character)

The *.minMaxMean.csv file for OW444 has NAs in the date column;the time series is less than 12 months to-date.

ateucher commented 5 years ago

@stephhazlitt would you expect to the result to still have the Historical_Daily_Average, Historical_Daily_Minimum, and Historical_Daily_Maximum columns (filled with NA) or just drop those columns entirely?

stephhazlitt commented 5 years ago

I lean to keeping the same API with NAs with the thought that there may be a downstream use or expectation in other bcgroundwater functions for those columns?

ateucher commented 5 years ago

Ok, I think that makes sense. Thanks

ateucher commented 5 years ago

Should work now!