search

bcgov / bcgroundwater

An R package to facilitate analysis and visualization of groundwater data from the British Columbia groundwater observation well network
Apache License 2.0
20 stars 4 forks source link

Fix newdata #6

Closed jayrbrown closed 9 years ago

jayrbrown commented 9 years ago

The source data has changed substantially from what the original function expects. The goal of this new function is simply to take new data and set it up in the original format the rest of the functions expect.

New function readGWLdata2 takes 4 args.

ateucher commented 9 years ago

Fantastic, thanks so much @jayrbrown. I will look it over - on first glance looks great!

jayrbrown commented 9 years ago

My pleasure! I'm excited to participate. I think your work is excellent, I learned things.

Jay

On Fri, Jun 12, 2015 at 10:06 AM, Andy Teucher notifications@github.com wrote:

Fantastic, thanks so much @jayrbrown https://github.com/jayrbrown. I will look it over - on first glance looks great!

— Reply to this email directly or view it on GitHub https://github.com/bcgov/bcgroundwater/pull/6#issuecomment-111559181.

Jay Brown Senior Project Manager Easy Metrics Inc.

Direct: 604.961.2762

ateucher commented 9 years ago

Hi Jay - sorry again for the silence. I had a couple more suggestions, then I think we can merge it!

jayrbrown commented 9 years ago

Hi Andy,

No worries at all. I made the changes and pushed it up. I'm very happy it seems useful. They sure changed the source dramatically. It would be nice if they had raw data feed that might pull the info from their popup window as well. Is there such a thing?

Cheers, Jay

On Tue, Jul 7, 2015 at 2:38 PM, Andy Teucher notifications@github.com wrote:

Hi Jay - sorry again for the silence. I had a couple more suggestions, then I think we can merge it!

— Reply to this email directly or view it on GitHub https://github.com/bcgov/bcgroundwater/pull/6#issuecomment-119350370.

Jay Brown Senior Project Manager Easy Metrics Inc.

Direct: 604.961.2762

ateucher commented 9 years ago

Great, thanks Jay.

You can download all of the data about all wells in B.C. (including the monitoring wells) here: http://catalogue.data.gov.bc.ca/dataset/ground-water-wells-spatial-view-with-attribute-info. It's a large download, as there are over 100,000 wells in the province.

jayrbrown commented 9 years ago

Excellent! I'll check it out, maybe there is a better way with a line on the full dataset.

Cheers, Jay

On Wed, Jul 8, 2015 at 10:18 AM, Andy Teucher notifications@github.com wrote:

Great, thanks Jay.

You can download all of the data about all wells in B.C. (including the monitoring wells) here: http://catalogue.data.gov.bc.ca/dataset/ground-water-wells-spatial-view-with-attribute-info. It's a large download, as there are over 100,000 wells in the province.

— Reply to this email directly or view it on GitHub https://github.com/bcgov/bcgroundwater/pull/6#issuecomment-119668736.

Jay Brown Senior Project Manager Easy Metrics Inc.

Direct: 604.961.2762