Hide uninformative plot captions in vignettes

[stephhazlitt]

I am not sure when this behaviour started, but the plots in the vignettes have right-aligned figure captions below them, which are derived from the chunk labels, e.g. plot of chunk convert. I am not a fan. I suggest we remove them. See https://stackoverflow.com/questions/21329864/is-there-a-way-to-hide-figure-captions-when-using-knitr-and-pandoc-to-create-doc

[boshek]

Interesting. #131 re-rendered the vignettes and a new div got added: https://github.com/bcgov/bcmaps/blob/a55b2e806072709bfe046c7134e98001df8dc8a3/vignettes/add_points.Rmd#L63-L66

Not sure why the caption is being added but the fig.cap might work. We should just make sure that doesn't also nuke the alt text.

[ateucher]

Interesting - seems like an addition for accessibility that may have gone astray.

[ateucher]

Looks like that did it: https://bcgov.github.io/bcmaps/dev/articles/bcmaps.html

[stephhazlitt]

It looks like that figure label was the same as the alt tag, and so as @boshek raised, this change removes the alt as well. However, the alt tags that were auto generated were not informative (e.g., alt="plot of chunk plot-maps"). Perhaps we add in proper alt tags?

[ateucher]

That would be the best option for sure

[stephhazlitt]

🙌