bcgov / bcmaps

An R package of map layers for British Columbia
http://bcgov.github.io/bcmaps/
Apache License 2.0
73 stars 17 forks source link

Old version of NRD #54

Closed bevingtona closed 4 years ago

bevingtona commented 4 years ago

Just noticed that the Natural Resource Districts layer (called with the bcmaps function bcmaps::nr_districts()) is an old version of the districts. The data catalogue has a newer version (found here: https://catalogue.data.gov.bc.ca/dataset/natural-resource-nr-district).

The only difference is that the Vanderhoof and Fort St. James districs have been merged into a single district named Stuart Nechako.

Great package as always - my go to for quick access to pretty maps!

image

boshek commented 4 years ago

Thanks @bevingtona

Do you know if any of the other nr_* layers are impacted?

stephhazlitt commented 4 years ago

I think this issue speaks to the proposal to revamp bcmaps to either (i) use bcdata under the hood to access these layers programmatically (as opposed to via a stored copy in bcmapsdata) or (ii) deprecate/defunct many of the bcmaps functions with a note to use bcdata and morph bcmaps into a bc mapping utilities package.

stephhazlitt commented 4 years ago

Do you know if any of the other nr_* layers are impacted?

It is likely that many/some of the layers in bcmapsdata have been superseded by newer versions. Perhaps a quick fix is to morph this issue into update the files raw-data of bcmapsdata?

boshek commented 4 years ago

@bevingtona I've updated the bcmapsdata package. Try reinstalling using this:

install.packages('bcmapsdata', repos='https://bcgov.github.io/drat/')

On my machine this works:

library(bcdata)
library(bcmaps)

bcdc_nr_districts <- bcdc_get_data('0bc73892-e41f-41d0-8d8e-828c16139337') 
bcmaps_nr_districts <- nr_districts()
identical(bcdc_nr_districts, bcmaps_nr_districts)
bevingtona commented 4 years ago

Thanks @boshek! Works great on my machine.

Not sure about the good points by @stephhazlitt. bcdata is definitely an easier package to keep up to date because it points to the catalogue. I like bcmaps because many of the basemapping layers that are often needed are so quick to call.

Thanks again for the quick fix!