search

bcgov / bcparks-ar-admin

BCParks Attendance and Revenue Admin
Apache License 2.0
4 stars 11 forks source link

[M] A&R -> Detect null/missing values #351

Open Dianadec opened 1 month ago

Dianadec commented 1 month ago

Description:

Currently no way to detect in system if / how much expected data is missing and where. Variance check only runs on entered values.

June 12/24 mtg notes:

Acceptance Criteria:

Given When Then

Given When Then

Development Checklist:

Dependencies

Wireframe(s):

Workflows:

Definition of Ready (Note: If any of these points are not applicable, mark N/A)

Definition of Done

Notes:

Dianadec commented 1 month ago

Questions for Refinement: discuss how the variance check only runs on entered values, and no way in A&R to see if/how much expected data is missing/where. How can this be addressed?

Dianadec commented 1 month ago

Refinement summary: Want to find data; not change calculation Wants to check for missing values from past years Flag for missing

--> Need to create a design to show what this would look like. Eg: a report? or the Review Data screen

Outstanding questions:

nicolebottoms commented 1 month ago

option to add a filter for missing data potentially? and then have the null value as a part of the variance report export? part of a larger thing to flag, the variance report does have a few bugs with how the data is displayed in the report snip

Dianadec commented 1 month ago

@nicolebottoms are these the bugs you mentioned/related tix? any others? the full list of A&R bugs I'm seeing is in this view: https://github.com/orgs/bcgov/projects/49/views/9?filterQuery=repo%3A%22bcgov%2Fbcparks-ar-admin%22%2C%22bcgov%2Fbcparks-ar-api%22+bug

277

279

348

nicolebottoms commented 1 month ago

277 separate from the variance export issue, but that is tied to the null value request.

279 no idea about this one honestly, it looks to be more of a design and 'make it pretty' thing.

348 also unrelated, this is for the uploading and exporting of historical data, i think its captured in another ticket but i couldn't see it.

the variance report exports each variance into one cell, i've attached a snip below: image in order to make this more useable and easier to interpret, each variance should be in its own column (red and blue circles). to make this readable i have to manipulate the data to separate the data in the cell, which takes time, and for other users may not be possible depending on their excel skills. i have no idea the best way to make that possible, whether it is easier for each variance to be on its own line, or if it should be in separate columns.

Dianadec commented 1 month ago

Thanks @nicolebottoms ! I'll add that bug as a separate ticket -> https://github.com/bcgov/bcparks-ar-admin/issues/357 cc @meyerdarcie

Dianadec commented 1 month ago

option to add a filter for missing data potentially? and then have the null value as a part of the variance report export? part of a larger thing to flag, the variance report does have a few bugs with how the data is displayed in the report snip

Cam said this wouldn't be the right spot.

We need to find entries that have never been entered. Provide some UI way of finding that.

Next steps: dev/designer work together on #356

Dianadec commented 2 weeks ago

Designs are in the midst of approvals - we can pull this out of blocked once this has been updated with the design. cc @meyerdarcie

davidclaveau commented 1 week ago

@manuji this feature is in DEV now and ready for review!