bcgov / bcparks-ar-admin

BCParks Attendance and Revenue Admin
Apache License 2.0
4 stars 11 forks source link

A&R: update to "Marine Sites" sub-areas #368

Closed nicolebottoms closed 1 month ago

nicolebottoms commented 2 months ago

Description:

This ticket is to combine the following sub areas into one called "Marine Sites"

Changes:

Acceptance Criteria:

Development Checklist:

Dependencies

Relevant documentation as reference

Definition of Ready

Definition of Done

Notes:

davidclaveau commented 1 month ago

@manuji this migration is ready for TEST. I've run it locally and in DEV and it looks like everything is working as expected 😄

Once this is in TEST, I'll just need to create the new "Marine Sites" subarea and then run the migration against it. Then it should be good for smoke testing!

The outcome is that Mount Titus, Phillips Creek, Wolf River, Rainbow Island, and Upper Campbell will all have their records combined into this "Marine Sites" subarea (it's just for Backcountry Camping - so People and Gross Camping Revenue will be added up across the old subareas).

The old subareas will then get their "historical" tag and all be locked, but still visible in the admin. The variance records tied to these old subareas will not be combined for Marine Sites, so Marine Sites won't have any variance records tied to them even if the old subareas might have. This is expected and has been cleared by Nicole and Sally!

Let me know if you have any questions!

davidclaveau commented 1 month ago

I made a PR for the frontend to show grossCampingRevenue data items when a record is legacy/historic.

Seems like this was initially a business decision to only show people data items for legacy records, as legacy records could be vastly different. Doesn't show any issues with adding grossCampingRevenue data for these new legacy records, or any past legacy records.

Image

manuji commented 1 month ago

Tested on TEST: Passed

Notes:

Passing to PO review.

JLWade commented 1 month ago

moving to done and data change can be updated in prod