bcgov / bcparks-ar-api

BCParks Attendance and Revenue Backend.
Apache License 2.0
2 stars 11 forks source link

Change Null/Missing Export Columns for Easier Filtering #374

Open davidclaveau opened 1 month ago

davidclaveau commented 1 month ago

Description:

When I open up a recently downloaded Null/Missing export, I would like to see the Bundle, Park, Subarea, and Months in separate columns so it's easier to filter the data.

Right now, the Bundle, Park, Subarea and Months are in rows, but it would be easier to filter the data if these items were in columns instead.

Acceptance Criteria:

Given I am an A&R user When I export the A&R Missing data Then I get an excel spreadsheet where the Bundle, Park, Subarea, and Months are in separate columns

Development Checklist:

Definition of Ready (Note: If any of these points are not applicable, mark N/A)

Definition of Done

Notes:

davidclaveau commented 1 month ago

Hey @manuji this is ready to be moved to TEST now!

The Missing Export should now have Bundle, Park, Subarea and Month columns so it's easier for the user to filter the data in the spreadsheet.

This means the data is a little haphazard in how it's displayed, as items are still written by the old setup (by bundle, then park, then subarea, and then in a monthly order) - so it might look odd to see things printed out of order, but that's expected behaviour!

Let me know if you have any questions!

Image

Dianadec commented 4 weeks ago

@manuji does this need further testing?

manuji commented 4 weeks ago

Hi @Dianadec , I will update the status today. Thank you!

manuji commented 3 weeks ago

Tested on TEST: Pending

davidclaveau commented 3 weeks ago

I will aim to add a fix to this in #377 when I apply an overall fix to the export!

davidclaveau commented 3 days ago

@manuji this fix will be in PR #383

The issue arose when the exporter misinterpreted specialized names containing commas, like ȽÁU,WELṈEW̱/John Dean Park. The CSV file incorrectly split these names into separate cells, treating the comma as a delimiter. Names with commas should be properly "escaped" and displayed now that we know what to look for!