Change spacing for BN on initial page

bcgov / business-ar

business registry annual report

BSD 3-Clause "New" or "Revised" License

0 stars 15 forks source link

Closed deetz99 closed 2 months ago

deetz99 commented 3 months ago

The BN should be formatted with a space between the BN9 and the other 6 characters.

example: 986395507BC0001 should be formatted as: 986395507 BC0001

janisrogers commented 2 months ago

The BN is not showing up on my test companies, but it looks good in the pull request. Is that considered 'tested'?

deetz99 commented 2 months ago

Not all test/dev business have a BN associated with them, so if theres no BN on the business, it won't be displayed.

janisrogers commented 2 months ago

Two of my test companies (BC0025735 and BC0878280) have BNs in COLIN, but they don't show up in the AR filing.

deetz99 commented 2 months ago

Strange, they are both returning null in the requests.

deetz99 commented 2 months ago

@janisrogers

The test data was loaded from a spreadsheet that was missing the BN. We added them in now, please try again.

janisrogers commented 2 months ago

Looks good.