bcgov / business-ar

business registry annual report
BSD 3-Clause "New" or "Revised" License
0 stars 6 forks source link

ui-Rename #250

Closed deetz99 closed 1 week ago

deetz99 commented 1 week ago
pwei1018 commented 1 week ago

/gcbrun

bcregistry-sre commented 1 week ago

Temporary Url for review: https://business-ar-dev--pr-250-pwsgm3d2.web.app

deetz99 commented 1 week ago

/gcbrun

@pwei1018 The temp url config needs to be updated. The NUXT_BAR_API_URL is set incorrectly, it's pointing to the NUXT_BASE_URL currently

bcregistry-sre commented 1 week ago

Temporary Url for review: https://business-ar-dev--pr-250-pwsgm3d2.web.app

pwei1018 commented 1 week ago

/gcbrun

@pwei1018 The temp url config needs to be updated. The NUXT_BAR_API_URL is set incorrectly, it's pointing to the NUXT_BASE_URL currently

Anyone has permission can go here to update the configuration. https://console.cloud.google.com/cloud-build/triggers;region=northamerica-northeast1/edit/1aa7887a-119f-4e96-996d-36016cc439b4?project=yfthig-dev

Or let me know what value do you want update with it.

bcregistry-sre commented 1 week ago

Temporary Url for review: https://business-ar-dev--pr-250-pwsgm3d2.web.app

bcregistry-sre commented 1 week ago

Temporary Url for review: https://business-ar-dev--pr-250-pwsgm3d2.web.app

deetz99 commented 1 week ago

@pwei1018 Hey thanks, it's saying I don't have access though.

The NUXT_BAR_API_URL is being set to the temporary url. Screenshot 2024-06-27 at 4 27 39 PM

But it should be set to the dev api, in this case "https://business-ar-api-dev-dy4loprnwa-nn.a.run.app"

pwei1018 commented 1 week ago

/gcbrun

bcregistry-sre commented 1 week ago

Temporary Url for review: https://business-ar-dev--pr-250-pwsgm3d2.web.app

pwei1018 commented 1 week ago

@pwei1018 Hey thanks, it's saying I don't have access though.

The NUXT_BAR_API_URL is being set to the temporary url. Screenshot 2024-06-27 at 4 27 39 PM

But it should be set to the dev api, in this case "https://business-ar-api-dev-dy4loprnwa-nn.a.run.app"

I should fixed it. Can you verify it?

deetz99 commented 1 week ago

Yes that seems to work now, thank you!