INVESTIGATE - Fix differences in effective date and or time

Maribeth-Wilson commented 2 weeks ago

There is a difference in effective dates. This could cause implications – users submitting in BCROS, not COLIN, there is a difference in time (2 minutes) in ledger vs actual filing time (please let me know if you need more info) - Elizabeth has confirmed that there could be possible implications of this and could result in additional phone calls to Joshua’s unit.

This one, issue with date and time – filed in BCROS on Aug 20 at 8:57pm but reflecting in COLIN as August 21 at 8:00am. It was also filed before the anniversary date.

Maribeth-Wilson commented 2 weeks ago

@nsmenon8890 - fyi

Maribeth-Wilson commented 1 week ago

@nsmenon8890 - FYI

EPortman commented 1 week ago

An update on this ticket

I updated the data in Google Cloud so that all of the data fields are consistent when an AR is filed. Here is an example below.

Even with the data being consistent on the Business AR side of things, Colin still displays the effective date to be something different - usually a couple of minutes in the future, but sometimes as much as an entire day.

It seems as if something is happening to the effective date in the post request that gets sent to Lear which is located here.

https://github.com/bcgov/lear/blob/f045c27b19792ea63e9596cf2313148f6432063f/colin-api/src/colin_api/resources/filing.py#L90-L93

Further work needs to be done on this issue, specifically finding out why Lear is changing the effective date.

@ozamani9gh once the CD gets implemented for the jobs we can add a bunch of logging to the process_paid_filings job (job that pushes data to colin) to better view what is going wrong.

ozamani9gh commented 1 week ago

We believe the issue is in COLIN_API in lear:

bcgov / business-ar

INVESTIGATE - Fix differences in effective date and or time #307