19698 Added Account-Id to auth api call + check for null auth info + small cleanup

severinbeauvais commented 7 months ago

Issue #: bcgov/entity#19698

Description of changes:

app version = 5.8.15
added get after set to update store
added check for empty auth info when re-fetching ting business info
added some safety checks when updating prepopulated data (ie, new holding/primary business)
moved accountId computed to store
added Account-Id header to fetchAuthInfo()
deleted some unused getters/local code
cleaned up some App unit tests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

severinbeauvais commented 7 months ago

/gcbrun

bcregistry-sre commented 7 months ago

Temporary Url for review: https://business-create-dev--pr-650-dtecq19o.web.app

SB says, try this one (as BCREG0020/Severin Dev Account): https://business-create-dev--pr-650-dtecq19o.web.app/amalg-reg-information?id=TaUQpULq2Z&accountid=3040

severinbeauvais commented 7 months ago

Test results

As BCREG0020/Severin Dev Account:

Note the 3 businesses that display as "affiliate to view". Those businesses are either affiliated to a different account under BCREG0020 or to a different login altogether.

As a staff user:

Note that all businesses display as affiliated (even though they aren't) because this is a staff (IDIR) login.

bcgov / business-create-ui