19774 Fixed null officer email schema error

bcgov / business-create-ui

BC Registry Services - Legal Entities - Create Incorporation Application

Apache License 2.0

7 stars 48 forks source link

19774 Fixed null officer email schema error #651

Closed severinbeauvais closed 9 months ago

severinbeauvais commented 9 months ago

Issue #: bcgov/entity#19774

Description of changes:

app version = 5.8.11
delete officer email if it's null

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

severinbeauvais commented 9 months ago

After this change, you can see that parties[0].officer and parties[3].officer have an email property but the other 2 don't. This passes schema validation.

severinbeauvais commented 9 months ago

/gcbrun

bcregistry-sre commented 9 months ago

Temporary Url for review: https://business-create-dev--pr-651-pp38jdpg.web.app

SB says, try this: https://business-create-dev--pr-651-pp38jdpg.web.app/amalg-short-review-confirm?id=TNVSuDNaw6&accountid=2288 (As BCREG0020, you can submit this, but don't pay for it, please! This will allow me to cancel the payment and get back to the draft.)