19745 Implemented compatible entity type check for adoptee businesses

bcgov / business-create-ui

BC Registry Services - Legal Entities - Create Incorporation Application

Apache License 2.0

7 stars 47 forks source link

19745 Implemented compatible entity type check for adoptee businesses #654

Closed severinbeauvais closed 7 months ago

severinbeauvais commented 7 months ago

Issue #: bcgov/entity#19745

Description of changes:

app version = 5.8.14
imported updated correct-name shared component
now filter adoptee businesses here instead of in shared component
added filter for entity type
added test suite

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

severinbeauvais commented 7 months ago

/gcbrun

bcregistry-sre commented 7 months ago

Temporary Url for review: https://business-create-dev--pr-654-90fblr75.web.app

SB says, try this: https://business-create-dev--pr-654-90fblr75.web.app/amalg-reg-information?id=TaUQpULq2Z&accountid=3040

severinbeauvais commented 7 months ago

Before (ie, in Dev):

After (ie, in preview site):

severinbeauvais commented 7 months ago

bcgov / business-create-ui

19745 Implemented compatible entity type check for adoptee businesses #654

Before (ie, in Dev):

After (ie, in preview site):

When there are no compatible TING businesses to adopt the name from: