19044 - Amalgamation unit tests

bcgov / business-create-ui

BC Registry Services - Legal Entities - Create Incorporation Application

Apache License 2.0

7 stars 48 forks source link

19044 - Amalgamation unit tests #655

Closed ketaki-deodhar closed 9 months ago

ketaki-deodhar commented 9 months ago

Issue #: /bcgov/entity#19044

Description of changes:

Added unit tests in:

AmalgamationBusinessInfo.spec.ts
AmalgamationInformation.spec.ts
AmalgamationPeopleRoles.spec.ts
AmalgamationReviewConfirm.spec.ts
PeopleAndRoles.spec.ts

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

ketaki-deodhar commented 9 months ago

What about this one?

https://github.com/bcgov/business-create-ui/blob/964251f344e736290f16717841450cbee4a810ad/tests/unit/AmalgamationShareStructure.spec.ts#L32

For Short form, Share structure is not a step and is only shown in Review and Confirm step as read only.

severinbeauvais commented 9 months ago

For Short form, Share structure is not a step and is only shown in Review and Confirm step as read only.

Oh, right. Please remove that comment. Thanks!