19750 and 19805 - fixed error handling + fixed party index bug

bcgov / business-create-ui

BC Registry Services - Legal Entities - Create Incorporation Application

Apache License 2.0

7 stars 48 forks source link

19750 and 19805 - fixed error handling + fixed party index bug #657

Closed severinbeauvais closed 9 months ago

severinbeauvais commented 9 months ago

Issue #: bcgov/entity#19750 and bcgov/entity#19805

Description of changes:

app version = 5.9.2
fixed error handling bug (missing await)
refactored ListPeopleAndRoles to retain original index for actions
removed unneeded code in buildAmalgamationFiling()
updated some comments

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

severinbeauvais commented 9 months ago

/gcbrun

bcregistry-sre commented 9 months ago

Temporary Url for review: https://business-create-dev--pr-657-or2ets8j.web.app

SB says, try these:

Compare the above with the full list of People and Roles on the Review page. You'll see that the completing party is not always index[0] but editing it works correctly in all cases.